Skip to content

Use interface instead of implementation in Endpoint properties #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 2, 2023
Merged

Use interface instead of implementation in Endpoint properties #104

merged 2 commits into from
Apr 2, 2023

Conversation

@babrekel
Copy link
Contributor

@babrekel babrekel commented Mar 31, 2023 •
edited
Loading

The problem is described in #68.

The endpoint properties should be defined as interfaces instead of classes so that they are also suitable for Moq tests. Additionally, the IChatEndpoint interface should be added as a property.

This PR replaces #69 as it would otherwise create a conflict between the changes.

Note that this is a breaking change.

@OkGoDoIt
Copy link
Owner

OkGoDoIt commented Apr 2, 2023

Thanks @babrekel!

@OkGoDoIt OkGoDoIt merged commit d30ead8 into OkGoDoIt:master Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@babrekel @OkGoDoIt